Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password rules and password change page for Mountain Warehouse #865

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

homsar
Copy link
Contributor

@homsar homsar commented Jan 6, 2025

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

for change-password-URLs.json

  • There is no Well-Known URL for Changing Passwords (https://example.com/.well-known/change-password)
  • The URL either makes the experience better or no worse than being directed to just the domain in a non-logged-in state

The default password rules generate passwords that are rejected by mountainwarehouse.com as too long; the quirk added by this PR restricts the length such that generated passwords are accepted.

screenshot

@homsar homsar changed the title add mountain warehouse Add password rules and password change page for Mountain Warehouse Jan 6, 2025
@rmondello
Copy link
Contributor

This change is a clear improvement. But they don't allow any special characters?

@homsar
Copy link
Contributor Author

homsar commented Jan 6, 2025

Thanks for pointing that out—I’d forgotten about the allowed option.

Experimenting with allowed symbols also gave me a slightly altered version of the password rules with constraints that I don’t think can be expressed in the quirk syntax—the quirk as written encodes the requirement in the screenshot above plus allowing most* of the allowed symbols from the below, which is sufficient to satisfy either set of rules, but is technically over constrained.

* I excluded square brackets as those appear to be reserved as sentinel values so can’t be included in a character class.

screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants