Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unset-var bug in 'verify_all.sh' script #749

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix unset-var bug in 'verify_all.sh' script #749

merged 1 commit into from
Jan 23, 2025

Conversation

gerlowskija
Copy link
Contributor

A variable 'artifact' was being referenced outside of the for-in loop that created it.

@gerlowskija
Fix unset-var bug in 'verify_all.sh' script
2259c52 
A variable 'artifact' was being referenced outside of the for-in loop
that created it.  Fixes that bug.
@gerlowskija gerlowskija marked this pull request as ready for review January 21, 2025 12:35
@gerlowskija
Copy link
Contributor Author

The smoke-tests pass for me without this PR, but on inspection it seems like a pretty clear bug. Not sure why my smoke-test run doesn't trigger this codepath, seemingly.

@janhoy
Copy link
Contributor

janhoy commented Jan 21, 2025

Checked out the PR branch and re-ran the smoke tester. It now gets past the previous error!

@HoustonPutman
Copy link
Contributor

Bizzare that this didn't happen before. I also ran into this when running the smoke tester. Let's merge this after the release. Unfortunately we can't commit to the release-0.9 branch until after a success/failure of the RC.

@janhoy
Copy link
Contributor

janhoy commented Jan 21, 2025

Bizzare that this didn't happen before. I also ran into this when running the smoke tester. Let's merge this after the release. Unfortunately we can't commit to the release-0.9 branch until after a success/failure of the RC.

Ah, ok. So a workaround for those who want to vote is checking out your PR branch or applying https://patch-diff.githubusercontent.com/raw/apache/solr-operator/pull/749.patch

@gerlowskija gerlowskija merged commit 47446f0 into apache:main Jan 23, 2025
2 checks passed
@gerlowskija gerlowskija deleted the fix_smoke_test_error branch January 23, 2025 17:33
@gerlowskija
Copy link
Contributor Author

Thanks all for the review - sorry you hit this Jan!

gerlowskija added a commit that referenced this pull request Jan 23, 2025
@gerlowskija
Fix unset-var bug in 'verify_all.sh' script (#749)
38169fe 
A variable 'artifact' was being referenced outside of the for-in loop
that created it.  Fixes that bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhoy janhoy janhoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerlowskija @janhoy @HoustonPutman