Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve]Support Sink input table name. #253

Closed
wants to merge 11 commits into from

Conversation

zhangshenghang
Copy link
Member

Purpose of this pull request

In Sink, only tables that already exist in the library can be selected. Modify it so that tables that do not exist in the library can also be set.

display.mp4

Check list

@arshadmohammad
Copy link
Collaborator

Thank you, @zhangshenghang, for your PRs. can you please resolve this PR conflict.

@arshadmohammad
Copy link
Collaborator

@zhangshenghang,
It appears that after selecting a non-existing table, the system does not allow the selection of an existing table.

@zhangshenghang
Copy link
Member Author

zhangshenghang commented Jan 8, 2025

thanks @arshadmohammad , Has been fixed. PTAL.

@arshadmohammad
Copy link
Collaborator

It appears that the pull request has not been properly rebased. base commit order is not correct.

@zhangshenghang
Copy link
Member Author

@arshadmohammad hi , I have merged.

@arshadmohammad
Copy link
Collaborator

arshadmohammad commented Jan 9, 2025

This patch does not apply on latest code. https://github.com/apache/seatunnel-web/pull/253.patch, check where it is wrong.

@Hisoka-X
Copy link
Member

Hisoka-X commented Jan 9, 2025

Hi @arshadmohammad , I checked by git plugin, The patch already merged latest code.
image

@arshadmohammad
Copy link
Collaborator

I see there are 11 commits in this PR. @zhangshenghang can you please remove unnecessary commits.

I get following error when I apply this PR changes as patch
error: patch failed: seatunnel-ui/src/locales/en_US/project.ts:1098 error: seatunnel-ui/src/locales/en_US/project.ts: patch does not apply error: patch failed: seatunnel-ui/src/locales/zh_CN/project.ts:1065 error: seatunnel-ui/src/locales/zh_CN/project.ts: patch does not apply error: patch failed: seatunnel-ui/src/views/task/synchronization-definition/dag/configuration-form.tsx:78 error: seatunnel-ui/src/views/task/synchronization-definition/dag/configuration-form.tsx: patch does not apply error: patch failed: seatunnel-ui/src/views/task/synchronization-definition/dag/configuration-form.tsx:40 error: seatunnel-ui/src/views/task/synchronization-definition/dag/configuration-form.tsx: patch does not apply error: patch failed: seatunnel-ui/src/views/task/synchronization-definition/dag/configuration-form.tsx:80 error: seatunnel-ui/src/views/task/synchronization-definition/dag/configuration-form.tsx: patch does not apply error: patch failed: seatunnel-ui/src/views/task/synchronization-definition/dag/configuration-form.tsx:36 error: seatunnel-ui/src/views/task/synchronization-definition/dag/configuration-form.tsx: patch does not apply error: patch failed: seatunnel-ui/src/views/task/synchronization-definition/dag/types.ts:15 error: seatunnel-ui/src/views/task/synchronization-definition/dag/types.ts: patch does not apply error: patch failed: seatunnel-ui/src/views/task/synchronization-definition/dag/use-configuration-form.ts:32 error: seatunnel-ui/src/views/task/synchronization-definition/dag/use-configuration-form.ts: patch does not apply

@zhangshenghang
Copy link
Member Author

Okay, as there are many modifications, in order to avoid restoring errors, I will resubmit a PR.

@zhangshenghang
Copy link
Member Author

Resolved in #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants