perf: improve journal deletion #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roiocam
force-pushed
the
remove-logic-delete
branch
from
ea64f0d to
4fcceb1
Compare
Roiocam
changed the title
nvollmar
approved these changes
Apr 19, 2024
core/src/main/scala/org/apache/pekko/persistence/jdbc/journal/dao/JournalQueries.scala
Outdated
Show resolved
Hide resolved
|
I will check this after work |
He-Pin
reviewed
Apr 20, 2024
core/src/main/scala/org/apache/pekko/persistence/jdbc/journal/dao/JournalQueries.scala
Show resolved
Hide resolved
He-Pin
reviewed
Apr 20, 2024
core/src/main/scala/org/apache/pekko/persistence/jdbc/journal/dao/JournalQueries.scala
Outdated
Show resolved
Hide resolved
Roiocam
commented
Apr 21, 2024
| .filter(_.sequenceNumber <= maxSequenceNr) | ||
| .take(1) | ||
| .map(_.sequenceNumber) | ||
| .max |
There was a problem hiding this comment.
Seem like we could avoid max function here, I have compared max and top 1 execute plans, and the former seems to cost more.
TOP 1
Limit (cost=0.29..0.35 rows=1 width=8)
-> Index Only Scan Backward using event_journal_pkey on event_journal (cost=0.29..12.29 rows=200 width=8)
Index Cond: ((persistence_id = 'my-7'::text) AND (sequence_number <= 10000))
Max
Result (cost=0.35..0.36 rows=1 width=8)
InitPlan 1 (returns $0)
-> Limit (cost=0.29..0.35 rows=1 width=8)
-> Index Only Scan Backward using event_journal_pkey on event_journal (cost=0.29..12.79 rows=200 width=8)
Index Cond: ((persistence_id = 'my-7'::text) AND (sequence_number IS NOT NULL) AND (sequence_number <= 10000))
There was a problem hiding this comment.
The SQL before update.
select max(x2.x3) from (select "sequence_number" as x3 from "event_journal" where ("persistence_id" = ?) and ("sequence_number" <= ?) order by "sequence_number" desc limit 1) x2
The SQL after update.
select "sequence_number" from "event_journal" where ("persistence_id" = ?) and ("sequence_number" <= ?) order by "sequence_number" desc limit 1
|
Cool~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #155, improve the deletion performance.