Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-12016. Fixed duplicate entries when changing path in DU page #7657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devabhishekpal
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-12016. Fixed duplicate entries when changing path in DU page

Please describe your PR in detail:
Previously:

  • The Disk Usage metadata details are not being set properly. We are using an array of keys and an array of values as the data for metadata table from which we generate the table data by mapping.
  • So if we change the path, specially while viewing the quota related details in the table i.e change table page and then change path - rows from second page will be repeated in the new path metadata causing it to be flaky.
  • We made separate calls to the summary and quota APIs and set the state twice. This causes issues with syncing up state as APIs might return in different times.

As a part of this PR:

  • We are going to use an array of objects to avoid recalculation of data we are already having, also we will make sure to remove duplicate entries when the path change triggers metadata table remount.
  • We are changing to simultaneously call both summary and quota APIs and set the state only once per path change.
  • Minor refactor of error checking method from overview page to common utils.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12016

How was this patch tested?

Patch was tested manually.

Screen.Recording.2025-01-07.at.15.00.08.mp4

@devabhishekpal
Copy link
Contributor Author

@devmadhuu @ArafatKhan2198 @dombizita could you help take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants