HDDS-11742. update scm HA metrics once, revert the changes in MiniOzo…

…neClusterImpl
apache · Nov 28, 2024 · 7094e8c · 7094e8c
1 parent e8f9afd
commit 7094e8c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 18 deletions.
diff --git a/...s/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java b/...s/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
@@ -1595,12 +1595,9 @@ public void start() throws IOException {
 
     setStartTime();
 
-    if (SCMHAUtils.isSCMHAEnabled(configuration) && getScmHAManager().getRatisServer().getLeaderId() != null) {
-      scmHAMetricsUpdate(getScmHAManager().getRatisServer().getLeaderId().toString());
-    } else {
-      // At this point leader is not known
-      scmHAMetricsUpdate(null);
-    }
+    RaftPeerId leaderId = SCMHAUtils.isSCMHAEnabled(configuration)
+        ? getScmHAManager().getRatisServer().getLeaderId() : null;
+    scmHAMetricsUpdate(Objects.toString(leaderId, null));
 
     if (scmCertificateClient != null) {
       // In case root CA certificate is rotated during this SCM is offline

diff --git a/...op-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java b/...op-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java
@@ -145,7 +145,7 @@ public class MiniOzoneClusterImpl implements MiniOzoneCluster {
   private CertificateClient caClient;
   private final Set<AutoCloseable> clients = ConcurrentHashMap.newKeySet();
   private SecretKeyClient secretKeyClient;
-  private static volatile MockedStatic mockDNStatic;
+  private static MockedStatic mockDNStatic = Mockito.mockStatic(HddsDatanodeService.class);
 
   /**
    * Creates a new MiniOzoneCluster with Recon.
@@ -571,16 +571,6 @@ private void setSecretKeyClient(SecretKeyClient client) {
     this.secretKeyClient = client;
   }
 
-  public static void mockDatanode() {
-    if (mockDNStatic == null) {
-      synchronized (MiniOzoneClusterImpl.class) {
-        if (mockDNStatic == null) {
-          mockDNStatic = Mockito.mockStatic(HddsDatanodeService.class);
-        }
-      }
-    }
-  }
-
   private static void stopDatanodes(
       Collection<HddsDatanodeService> hddsDatanodes) {
     if (!hddsDatanodes.isEmpty()) {
@@ -877,7 +867,6 @@ protected Gateway createS3G() {
      */
     protected List<HddsDatanodeService> createHddsDatanodes()
         throws IOException {
-      mockDatanode();
       List<HddsDatanodeService> hddsDatanodes = new ArrayList<>();
 
       // Override default datanode initial and current version if necessary