HDDS-12057. ReadReplicas should handle key names containing / (#7735)

apache · Jan 22, 2025 · 642b1c7 · 642b1c7
1 parent bb96826
commit 642b1c7
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ReadReplicas.java b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ReadReplicas.java
@@ -109,8 +109,11 @@ protected void execute(OzoneClient client, OzoneAddress address)
       String volumeName = address.getVolumeName();
       String bucketName = address.getBucketName();
       String keyName = address.getKeyName();
+      // Multilevel keys will have a '/' in their names. This interferes with
+      // directory and file creation process. Flatten the keys to fix this.
+      String sanitizedKeyName = address.getKeyName().replace("/", "_");
 
-      File dir = createDirectory(volumeName, bucketName, keyName);
+      File dir = createDirectory(volumeName, bucketName, sanitizedKeyName);
 
       OzoneKeyDetails keyInfoDetails
           = checksumClient.getKeyDetails(volumeName, bucketName, keyName);
@@ -128,13 +131,13 @@ protected void execute(OzoneClient client, OzoneAddress address)
       result.put(JSON_PROPERTY_FILE_SIZE, keyInfoDetails.getDataSize());
 
       ArrayNode blocks = JsonUtils.createArrayNode();
-      downloadReplicasAndCreateManifest(keyName, replicas,
+      downloadReplicasAndCreateManifest(sanitizedKeyName, replicas,
           replicasWithoutChecksum, dir, blocks);
       result.set(JSON_PROPERTY_FILE_BLOCKS, blocks);
 
       String prettyJson = JsonUtils.toJsonStringWithDefaultPrettyPrinter(result);
 
-      String manifestFileName = keyName + "_manifest";
+      String manifestFileName = sanitizedKeyName + "_manifest";
       System.out.println("Writing manifest file : " + manifestFileName);
       File manifestFile
           = new File(dir, manifestFileName);