Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-12024. Update try ozone with docker page #122

Merged

Conversation

@github-actions github-actions bot added the website-v2 Tasks for the new ozone website targeting the HDDS-9225-website-v2 branch label Jan 6, 2025
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ptlrs for working on this.

docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
@ptlrs ptlrs requested a review from adoroszlai January 10, 2025 07:22
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ptlrs for the update.

docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ptlrs for the update. PR for ozone-docker has been merged, so the sample docker-compose.yaml is available now.

I have a few trivial suggestions based on the rendered doc, otherwise it looks good to me.

docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @ptlrs. It's nice and concise as a quick start should be. For heading structure, I was thinking something like this:

# Try Ozone With Docker
## Prerequisites
## Running Ozone
### Obtain the Docker Compose Configuration
### Start the Cluster
### Verify the Deployment
- Run`docker compose ps`
- Run `ozone version`
- Check that Recon is accessible
## Configuration
## Next Steps

docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
@errose28 errose28 added the docs Changes updating documentation on the website label Jan 13, 2025
@ptlrs
Copy link
Author

ptlrs commented Jan 14, 2025

Thanks for the detailed reviews @adoroszlai and @errose28.

Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, just two minor comments

docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
docs/02-quick-start/01-installation/01-docker.md Outdated Show resolved Hide resolved
ptlrs and others added 2 commits January 20, 2025 13:52
Co-authored-by: Ethan Rose <[email protected]>
Co-authored-by: Ethan Rose <[email protected]>
@ptlrs ptlrs requested a review from adoroszlai January 21, 2025 19:14
@ptlrs ptlrs requested a review from errose28 January 21, 2025 19:14
Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continuous updates, LGTM

@adoroszlai adoroszlai merged commit 05598b2 into apache:HDDS-9225-website-v2 Jan 22, 2025
12 checks passed
@adoroszlai
Copy link
Contributor

Thanks @ptlrs for the doc, @errose28 for the review.

@ptlrs ptlrs deleted the HDDS-12024-try-ozone-with-docker branch January 22, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Changes updating documentation on the website website-v2 Tasks for the new ozone website targeting the HDDS-9225-website-v2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants