-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: Rename CONFIG_TESTING_SENSORTEST to CONFIG_SYSTEM_SENSORTEST #15698
Conversation
follow the change from: apache/nuttx-apps#2976 Signed-off-by: Xiang Xiao <[email protected]>
[Experimental Bot, please feedback here] No, this PR description does not meet the NuttX requirements. It's far too brief and lacks crucial information. Here's a breakdown of what's missing and how to fix it: Summary:
Impact:
Testing:
Example of a better Testing section:
nsh> help ls
nsh> help ls
By providing more complete information, reviewers can understand your changes, assess their impact, and verify that they work as intended. A well-written PR description significantly speeds up the review process and increases the likelihood of your contribution being accepted. |
Isnt this commit part of apache/nuttx-apps#2976? Why separate PR? :-) |
it's in the different git, can't in one pr. |
Braindead, sorry, long time no sleep!!! :D :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @xiaoxiang781216 :-)
Sorry for my faux pas :D Merging now together with apache/nuttx-apps#2976 as instructed :-)
Summary
follow the change from: apache/nuttx-apps#2976
Impact
Testing
ci