-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate includes across multiple files #15474
Conversation
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements, although it could be improved. Here's a breakdown: Strengths:
Weaknesses:
Recommendation: To strengthen this PR, expand the Impact and Testing sections. Example: Impact (Improved):
Testing (Improved): I confirm that changes are verified on local setup and works as intended:
Testing logs before change (sim:nsh - demonstrating no functional change):
Testing logs after change (sim:nsh - demonstrating no functional change):
By adding this level of detail, the PR becomes significantly stronger and inspires more confidence in the changes. |
ebe4a2f
to
a85202e
Compare
This commit cleans up redundant header file includes throughout the codebase. The changes include: - Removing duplicate #include directives that were present in the same file - Consolidating includes that were split across multiple lines unnecessarily - Removing unused includes that were no longer needed - Fixing some formatting issues with includes The changes improve code organization and maintainability by: - Reducing unnecessary dependencies - Making include dependencies more explicit - Following consistent include patterns - Removing dead code No functional changes are made - this is purely a code cleanup commit. Signed-off-by: Huang Qi <[email protected]>
Summary
This commit cleans up redundant header file includes throughout the codebase.
The changes include:
The changes improve code organization and maintainability by:
No functional changes are made - this is purely a code cleanup commit.
Impact
Minor
Testing
GitHub CI