Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2354] feat(client): Explicitly setting grpc netty based event loop threads to avoid too much threads #2355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[#2354] feat(client): Explicitly setting grpc netty based event loop threads to avoid too much threads #2355

wants to merge 2 commits into from
+42 −7

Conversation

zuston
Copy link
Member

@zuston zuston commented Jan 27, 2025

What changes were proposed in this pull request?

Introduing the config option to set the grpc netty based network impl event loop threads

Why are the changes needed?

Fix: #2354

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

Tests in the spark jobs

@zuston zuston requested a review from jerqi January 27, 2025 06:42
@github-actions GitHub Actions
Copy link

Test Results

 2 981 files  ±0   2 981 suites  ±0   6h 27m 42s ⏱️ -25s
 1 101 tests ±0   1 099 ✅ +1   2 💤 ±0  0 ❌ ±0 
13 789 runs  ±0  13 759 ✅ +1  30 💤 ±0  0 ❌ ±0 

Results for commit c020f5d. ± Comparison against base commit 3590940.

cchung100m
cchung100m approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks to @zuston 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchung100m cchung100m cchung100m approved these changes

@jerqi jerqi Awaiting requested review from jerqi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Explicitly grpc client thread pool number
2 participants
@zuston @cchung100m