Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2350] improvement(coordinator): Add metrics of active/lost server number #2351

Merged
merged 2 commits into from
Jan 26, 2025
Merged

[#2350] improvement(coordinator): Add metrics of active/lost server number #2351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2433cdb
[#2350] improvement(coordinator): Add metrics of active/lost server n…
Jan 24, 2025
d8aa241
fix
Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.io.InputStreamReader;
import java.io.OutputStreamWriter;
import java.nio.charset.StandardCharsets;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
Expand Down Expand Up @@ -171,6 +172,16 @@ void nodesCheck() {

CoordinatorMetrics.gaugeUnhealthyServerNum.set(unhealthyNodes.size());
CoordinatorMetrics.gaugeTotalServerNum.set(servers.size());
CoordinatorMetrics.gaugeLostServerNum.set(lostNodes.size());

// get the active server num.
Set<String> allServers = new HashSet<>(servers.keySet());
allServers.removeAll(excludedNodes);
for (ServerNode unhealthyNode : unhealthyNodes) {
allServers.remove(unhealthyNode.getId());
}
CoordinatorMetrics.gaugeActiveServerNum.set(allServers.size());

} catch (Exception e) {
LOG.warn("Error happened in nodesCheck", e);
}
Expand Down
8 changes: 6 additions & 2 deletions coordinator/src/main/java/org/apache/uniffle/coordinator/metric/CoordinatorMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
import org.apache.uniffle.common.util.RssUtils;

public class CoordinatorMetrics {

private static final String ACTIVE_SERVER_NUM = "active_server_num";
private static final String LOST_SERVER_NUM = "lost_server_num";
private static final String TOTAL_SERVER_NUM = "total_server_num";
private static final String RUNNING_APP_NUM = "running_app_num";
private static final String TOTAL_APP_NUM = "total_app_num";
Expand All @@ -46,7 +47,8 @@ public class CoordinatorMetrics {
public static final String REMOTE_STORAGE_IN_USED_PREFIX = "remote_storage_in_used_";
public static final String APP_NUM_TO_USER = "app_num";
public static final String USER_LABEL = "user_name";

public static Gauge gaugeLostServerNum;
public static Gauge gaugeActiveServerNum;
public static Gauge gaugeTotalServerNum;
public static Gauge gaugeExcludeServerNum;
public static Gauge gaugeUnhealthyServerNum;
Expand Down Expand Up @@ -107,6 +109,8 @@ public static void updateDynamicGaugeForRemoteStorage(String storageHost, double
}

private static void setUpMetrics() {
gaugeLostServerNum = metricsManager.addGauge(LOST_SERVER_NUM);
gaugeActiveServerNum = metricsManager.addGauge(ACTIVE_SERVER_NUM);
gaugeTotalServerNum = metricsManager.addGauge(TOTAL_SERVER_NUM);
gaugeExcludeServerNum = metricsManager.addGauge(EXCLUDE_SERVER_NUM);
gaugeUnhealthyServerNum = metricsManager.addGauge(UNHEALTHY_SERVER_NUM);
Expand Down
Loading