[MINOR] fix(test): Fix flaky test for CoordinatorReconfigureNodeMaxTest#testReconfigureNodeMax #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
previously approved these changes
Jan 7, 2025
jerqi
reviewed
Jan 7, 2025
| @@ -131,9 +131,11 @@ public void testReconfigureNodeMax() throws Exception { | |||
| assertEquals(5, info.getServerToPartitionRanges().keySet().size()); | |||
|
|
|||
| // case3: recover its value to 10 | |||
| Thread.sleep(1000L); | |||
There was a problem hiding this comment.
@jerqi I added a new comment above this line. This sleep to make sure the last modification time of the tempConfFilePath file changed.
There was a problem hiding this comment.
You wait for a modification timestamp instead sleep.
jerqi
reviewed
Jan 9, 2025
| File tempConfFile = new File(tempConfFilePath); | ||
| long currentTime = System.currentTimeMillis(); | ||
| if (currentTime - tempConfFile.lastModified() < 1000) { | ||
| Thread.sleep(1000 - (currentTime - tempConfFile.lastModified())); |
There was a problem hiding this comment.
Could use Awaitility.await() instead of sleep?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix flaky test for CoordinatorReconfigureNodeMaxTest#testReconfigureNodeMax
Why are the changes needed?
Make CI stable.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.