Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] fix(test): Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize #2323

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

maobaolong
Copy link
Member

What changes were proposed in this pull request?

Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize

Why are the changes needed?

Do some efforts to make Ci more stable.

Does this PR introduce any user-facing change?

NO

How was this patch tested?

Existing UTs.

@maobaolong maobaolong changed the title Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize [MINOR] fix(test): Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize Jan 5, 2025
Copy link

github-actions bot commented Jan 5, 2025

Test Results

 2 966 files  ±0   2 966 suites  ±0   6h 30m 40s ⏱️ + 3m 22s
 1 100 tests ±0   1 098 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 774 runs  ±0  13 744 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 9e405f0. ± Comparison against base commit 3b0521a.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.60%. Comparing base (580b4f2) to head (9e405f0).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2323      +/-   ##
============================================
+ Coverage     51.19%   51.60%   +0.40%     
- Complexity     2936     2972      +36     
============================================
  Files           486      474      -12     
  Lines         24720    22683    -2037     
  Branches       2041     2090      +49     
============================================
- Hits          12656    11705     -951     
+ Misses        11274    10233    -1041     
+ Partials        790      745      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maobaolong maobaolong closed this Jan 5, 2025
@maobaolong maobaolong reopened this Jan 5, 2025
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maobaolong maobaolong merged commit a15751b into apache:master Jan 8, 2025
84 of 85 checks passed
@maobaolong
Copy link
Member Author

@jerqi Thanks for your review! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants