[#1872] improvement: Update the project directory name #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @maobaolong I cannot determine how the failed test connects to my change of proposal. It would be appreciated if you were could help me identify the root cause. Thanks. |
|
@cchung100m In fact there are some flaky tests and unluckily maybe you encountered some flaky tests, I just re-run the failed test for you, hope it will getting green after that. |
|
HI @maobaolong Thanks for the prompt reply. It is green now. 😄 |
jerqi
reviewed
Jan 6, 2025
release/create-package.sh
Outdated
| @@ -80,8 +80,8 @@ package_binary() { | |||
|
|
|||
| ${PROJECT_DIR}/build_distribution.sh | |||
|
|
|||
| BIN_ORIGIN_NAME="rss-${RELEASE_VERSION}-hadoop2.8.tgz" | |||
| BIN_DIR_NAME="rss-${RELEASE_VERSION}-hadoop2.8" | |||
| BIN_ORIGIN_NAME="apache-uniffle-${RELEASE_VERSION}-incubating-rss-hadoop2.8.tgz" | |||
There was a problem hiding this comment.
Maybe we don't need rss keyword.
There was a problem hiding this comment.
Thanks for the prompt reply and comments. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the project directory name
Why are the changes needed?
Fix: #1872
Does this PR introduce any user-facing change?
No.
How was this patch tested?
current UT