refactor(function_test): Generate bulk load files internally #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
rft_func_tests
branch
from
7c09271 to
1308b2a
Compare
acelyc111
force-pushed
the
rft_func_tests
branch
from
6f83417 to
b7d21dd
Compare
GehaFearless
approved these changes
Dec 15, 2023
empiredan
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the Pegasus function test
bulk_load_testwill downloadfiles from external site, it may break some ASF policies.
This patch make the test to generate bulk load test files internally, it make
the procedure transparent to developers, know what key-values are generated and
bulk loaded.