feat(slog): Remove slog related code #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
rm_slog
branch
2 times, most recently
from
5387758 to
c092b62
Compare
GehaFearless
previously approved these changes
Dec 13, 2023
empiredan
reviewed
Dec 14, 2023
empiredan
reviewed
Dec 14, 2023
Co-authored-by: Dan Wang <[email protected]>
empiredan
approved these changes
Dec 14, 2023
GehaFearless
approved these changes
Dec 14, 2023
|
To resolve #1693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Pegasus 2.4.0, there will be no new shared logs been created, since Pegasus 2.5.0, all shared logs will garbage collected, then there is no shared logs left. It's a time to remove all shared log related code.
This patch also ensure that there is slog left, otherwise, the server will crash when bootstrap.
This change should be mentioned as "behavior changes" in release notes.