feat(replica): add FileDataType as the parameter #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samunroyu
changed the title
Samunroyu
force-pushed
the
dev/yjw/parameterize-filedatatype
branch
2 times, most recently
from
80a8e66 to
a049bd3
Compare
acelyc111
reviewed
Dec 4, 2023
Samunroyu
force-pushed
the
dev/yjw/parameterize-filedatatype
branch
from
4bb8d46 to
2bfe595
Compare
acelyc111
previously approved these changes
Dec 5, 2023
acelyc111
approved these changes
Dec 5, 2023
empiredan
approved these changes
Dec 5, 2023
empiredan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The class replica_kms_info of key manager needs to be written with NonSensitive. Add FileDataType as the parameter of write_blob_to_file.
What is changed and how does it work?
Checklist
Tests
Code changes
src/replica/replica.h
src/replica/replica.cpp
src/replica/replica_disk_migrator.h
src/replica/replica_disk_migrator.cpp
src/replica/replication_app_base.h
src/replica/replication_app_base.cpp
src/replica/replica_stub.h
src/replica/replica_stub.cpp
src/replica/test/replica_test.cpp