[GOBBLIN-2190] Implement ActivityConfigurationStrategy for Temporal Activities #4093
+550
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blazer-007
changed the title
Blazer-007
changed the title
vsinghal85
reviewed
Feb 3, 2025
|
|
||
|
|
||
| /** | ||
| * Interface for defining timeout strategies for different Temporal activities. |
There was a problem hiding this comment.
[NIT] timeout strategies -> "activity configuration strategies"
|
|
||
| /** | ||
| * Interface for defining timeout strategies for different Temporal activities. | ||
| * Each strategy provides a method to retrieve the timeout duration based on the provided properties. |
There was a problem hiding this comment.
change as per scope of new class to something like -> "Each strategy provides a method to retrieve configuration details, such as timeout duration, based on the provided properties."
...oral/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/CommitStepWorkflowImpl.java
Show resolved
Hide resolved
.../org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java
Show resolved
Hide resolved
.../org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java
Show resolved
Hide resolved
| private static Duration getStartToCloseTimeout(ActivityType activityType, Properties props) { | ||
| ActivityConfigurationStrategy activityConfigurationStrategy = activityConfigurationStrategies.get(activityType); | ||
| if (activityConfigurationStrategy == null) { | ||
| return ActivityConfigurationStrategy.defaultStartToCloseTimeout; |
There was a problem hiding this comment.
Let's add log to track this scenario
...obblin/temporal/loadgen/workflow/impl/NestingExecOfIllustrationItemActivityWorkflowImpl.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| protected Promise<Integer> launchAsyncActivity(final WorkUnitClaimCheck wu) { | ||
| return Async.function(activityStub::processWorkUnit, wu); | ||
| protected Promise<Integer> launchAsyncActivity(final WorkUnitClaimCheck wu, final Properties props) { |
There was a problem hiding this comment.
Do we plan to add unit tests for this?
There was a problem hiding this comment.
Unit tests for older temporal classes needs to be done separately as it will required dedicated effort for this which is beyond the scope of this PR
...rc/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ProcessWorkUnitsWorkflowImpl.java
Show resolved
Hide resolved
.../java/org/apache/gobblin/temporal/util/nesting/workflow/AbstractNestingExecWorkflowImpl.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Implemented ActivityConfigurationStrategy
Created ActivityType Enum
Refactored the interfaces to pass properties
Tests
ActivityConfigurationStrategyTest
TemporalActivityUtilsTest
Commits