Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16991] Missing environmentConfig when retry/failover/recover task instance #16998

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

close #16991

Brief change log

  • Assemble environment when create task execution context
  • Add test case

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun
Copy link
Member Author

cc @reele

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reele
Copy link
Contributor

reele commented Feb 7, 2025

cc @reele

got. +1

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 806f051 into apache:dev Feb 7, 2025
70 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fix16991 branch February 7, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [FailedRecoverTaskInstanceFactory] Missing environmentConfig when recover failed task.
4 participants