Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-16947][UI] Task instance log details should always stay at the bottom #16947

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

imizao
Copy link
Contributor

@imizao imizao commented Jan 7, 2025

Purpose of the pull request

Task instance log details should always stay at the bottom.

Brief change log

The log details area for task instances should always remain scrolled to the bottom, allowing users to view the latest log output in real-time.

Final effect 1
12.gif

Final effect 2
123.gif

Verify this pull request

This pull request is code cleanup without any test coverage.

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Jan 7, 2025
@imizao imizao changed the title [Improvement][UI] Task instance log details should always stay at the… [Improvement][UI] Task instance log details should always stay at the bottom Jan 7, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the pull request notice first.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this feature needs disscussion. No all users needs this when the log is very large and refresh very fast.

@SbloodyS SbloodyS added the discussion discussion label Jan 8, 2025
@imizao
Copy link
Contributor Author

imizao commented Jan 8, 2025

Please follow the pull request notice first.

Well, should I use it like this? [Improvement-16947][UI] Task instance log details should always stay at the bottom

@imizao
Copy link
Contributor Author

imizao commented Jan 8, 2025

I think this feature needs disscussion. No all users needs this when the log is very large and refresh very fast.

Add a button that allows the user to manually control whether to scroll to the bottom, without forcing automatic scrolling. Would that work?

@imizao imizao changed the title [Improvement][UI] Task instance log details should always stay at the bottom [Improvement-16947][UI] Task instance log details should always stay at the bottom Jan 8, 2025
@imizao
Copy link
Contributor Author

imizao commented Jan 8, 2025

I think this feature needs disscussion. No all users needs this when the log is very large and refresh very fast.

Add a button that allows the user to manually control whether to scroll to the bottom, without forcing automatic scrolling. Would that work?

Like this.
12345.gif

@SbloodyS
Copy link
Member

SbloodyS commented Jan 9, 2025

Please follow the pull request notice first.

Well, should I use it like this? [Improvement-16947][UI] Task instance log details should always stay at the bottom

You can take a look at https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md

@SbloodyS
Copy link
Member

SbloodyS commented Jan 9, 2025

Add a button that allows the user to manually control whether to scroll to the bottom, without forcing automatic scrolling. Would that work?

I think it's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion discussion UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants