Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-21479 Use HttpJdkSolrClient as default SolrClient implementation #16891

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

Paul-Blanchaert
Copy link
Contributor

Description

PR for issue CAMEL-21479
Camel-Solr: Use HttpJdkSolrClient as default SolrClient implementation

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a CAMEL-21479 filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.

  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs some notes on the migration guide too.

@davsclaus
Copy link
Contributor

Can you include this file in the PR

modified:   dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/SolrEndpointBuilderFactory.java

Also as Andrea says we need something added to the 4.10 upgrade guide doc, see inside the docs folder from camel root dir

@davsclaus
Copy link
Contributor

@Paul-Blanchaert thanks for working on this - let us know when you have the last bit done. Ideally no later by end of this month to make it for the next 4.10 release

@Paul-Blanchaert
Copy link
Contributor Author

@davsclaus, sorry not to come back on this earlier... had to finish off other work this week... I should be able to give it some more attention beginning of next week.. so it should done by the end of month.

@davsclaus
Copy link
Contributor

deleted:    docs/components/modules/ROOT/examples/json/solrCloud.json
deleted:    docs/components/modules/ROOT/examples/json/solrs.json
modified:   dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/ComponentsBuilderFactory.java
modified:   dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/SolrComponentBuilderFactory.java
modified:   dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/SolrEndpointBuilderFactory.java

@Paul-Blanchaert
Copy link
Contributor Author

@davsclaus
I've updated some deprecated code in generated artifacts in an attempt to remove the build issues.
Can you initiate a new build? or can I trigger that?

@davsclaus davsclaus merged commit 8132e69 into apache:main Jan 28, 2025
2 of 4 checks passed
@davsclaus
Copy link
Contributor

okay lets merge this and manual regen. And if there is some other bits still needed you can get new code from main and send another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants