-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camel JBang Update #16874
base: main
Are you sure you want to change the base?
Camel JBang Update #16874
Conversation
97691fe
to
37de264
Compare
It is a bit confusing with CEQ vs Camel versions. I wonder if the CLI can show Camel and Runtime columns with version numbers. We ought to have the info, ala what you can do with
|
Good point, I expected this kind of comment, I added the runtime version information in the list like this
And the run can be executed with the Camel version:
I had to make some assumptions... but it is working, and I can translate Quarkus/Camel versions |
37de264
to
344048e
Compare
@@ -68,7 +73,7 @@ public class UpdateRun extends CamelCommand { | |||
boolean debug; | |||
|
|||
@CommandLine.Option(names = { "--quarkusMavenPluginVersion" }, | |||
defaultValue = "3.15.2") | |||
defaultValue = "3.17.7") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a constant for that in RuntimeType
|
||
return 0; | ||
if (!p.waitFor(240, TimeUnit.SECONDS)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this 240 seconds an option we should make configurable ?
if (Files.list(Path.of(".")) | ||
.filter(f -> f.getFileName().toString().equals("pom.xml")) | ||
.count() | ||
== 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can refactor as Path.of(".")).noneMatch(f -> f.getFileName().toString().equals("pom.xml"))
cb3a489
to
0021d33
Compare
0021d33
to
30245bd
Compare
Handle quarkus Handle extra repos Handle downloads concurrently Refactor camel update
30245bd
to
fe75c9a
Compare
It is possible to define extra recipes and artifacts like Considering this example, the applied recipes are the following: |
658756f
to
45e19e7
Compare
@Croway it would be good to have this ready mon/tue next week |
sure thing, I'll do another round of test today and set it to ready for review. Thanks for the heads up |
Use openrewrite recipes via Camel JBang to update Camel, Camel Spring Boot and Camel Quarkus applications:
update list
shows versions that can be used for upgradesupdate run $VERSION
execute the update