Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish yapf upgrade to 0.43.0 #33548

Closed
wants to merge 6 commits into from
Closed

Finish yapf upgrade to 0.43.0 #33548

wants to merge 6 commits into from

Conversation

jrmccluskey
Copy link
Contributor

The yapf version was updated in #33112 but the change was not extended to the linting/formatting workflows, keeping them at 0.29.0 and not breaking the workflows because the code base had not been re-formatted. This updates the workflows and reformats the codebase in one go.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@jrmccluskey
Copy link
Contributor Author

jrmccluskey commented Jan 9, 2025

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@jrmccluskey
Copy link
Contributor Author

Looks like there's probably more work to do here in terms of tests failing (not able to account for a lot of the failures easily) so I'll just revert the version upgrade instead.

@jrmccluskey jrmccluskey closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant