Fix: Replace deprecated DataFrame.applymap with map for compatibility #33532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
damccorm
reviewed
Jan 13, 2025
| @@ -420,7 +420,7 @@ def _display_dataframe(self, data, update=None): | |||
| format_window_info_in_dataframe(data) | |||
| # Convert the dataframe into rows, each row looks like | |||
| # [column_1_val, column_2_val, ...]. | |||
| rows = data.applymap(lambda x: str(x)).to_dict('split')['data'] | |||
| rows = data.apply(lambda col: col.map(lambda x: str(x))).to_dict('split')['data'] | |||
There was a problem hiding this comment.
Hey, this change looks good, but it looks like it breaks our formatting. Would you mind running the linter and formatter? https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95653376#PythonTips-LintandFormattingChecks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the deprecated DataFrame.applymap function with map in the file pcoll_visualization.py. The change ensures compatibility with newer versions of pandas and avoids deprecation warnings during execution.
The modification is minimal and focuses only on updating the function to maintain functionality and improve codebase compatibility.