Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka add counters v1 uw2 #33503

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Naireen
Copy link
Contributor

@Naireen Naireen commented Jan 6, 2025

Add per worker metadata on metrics propaged over FnApi. This is on top of #33408

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Naireen Naireen force-pushed the kafka_add_counters_V1_uw2 branch from 5b28665 to 5f28d22 Compare January 6, 2025 22:17
@Naireen
Copy link
Contributor Author

Naireen commented Jan 6, 2025

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 6, 2025

Run Java_IOs_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 6, 2025

Run Java_Pulsar_IO_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 6, 2025

Run Python_Coverage PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 7, 2025

Run Java PreCommit

2 similar comments
@Naireen
Copy link
Contributor Author

Naireen commented Jan 7, 2025

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 7, 2025

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 7, 2025

tests failing due to #28957

@Naireen Naireen marked this pull request as ready for review January 7, 2025 19:58
@Naireen
Copy link
Contributor Author

Naireen commented Jan 7, 2025

Run Java PreCommit

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Naireen
Copy link
Contributor Author

Naireen commented Jan 7, 2025

assign set of reviewers @johnjcasey @sjvanrossum

flakey tests - want to get the review started in the meanwhile, but will wait on the tests to pass before I merge.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @damccorm for label build.
R: @damondouglas for label io.
R: @sjvanrossum for label kafka.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Naireen
Copy link
Contributor Author

Naireen commented Jan 7, 2025

Run Java PreCommit

1 similar comment
@Naireen
Copy link
Contributor Author

Naireen commented Jan 7, 2025

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 7, 2025

Run Java PreCommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant