-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new precommit workflow to test flink container #33206
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple minor comments, overall LGTM though
{ | ||
"https://github.com/apache/beam/pull/33206": "testing the new flink container workflow" | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work until the PR is merged
(github.event_name == 'pull_request_target' && | ||
github.base_ref == 'master' && | ||
github.event.pull_request.draft == false) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this full condition - just github.event_name == 'pull_request_target'
should be fine, often you want stuff to run on draft prs anyways.
Let me merge this PR first since I need to do more tests and will address your comments with that PR. Thanks. |
Address #33180
Will trigger this later with:
For now, just manually trigger this for developing.
Create PreCommit Flink Container workflow
Description
This PR introduces a new PreCommit workflow to test Flink container functionality across Go, Python, and Java SDKs. The workflow runs combine load tests in each language to verify the Flink container's functionality.
Key Features
Implementation Details
Notes
Fixes
N/A
Related PRs
N/A
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.