Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add histogram to metrics container #33043

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Naireen
Copy link
Contributor

@Naireen Naireen commented Nov 7, 2024

Add histogram to metrics container. The histogram representation here is the DataflowHistogramValue representation.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 2 times, most recently from 7ba2869 to 44cf182 Compare November 7, 2024 22:08
@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 5 times, most recently from 7db8de1 to 2f9125a Compare November 11, 2024 17:33
@Naireen
Copy link
Contributor Author

Naireen commented Nov 11, 2024

Run Java_IOs_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Nov 11, 2024

Run Go PreCommit

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 3 times, most recently from 3518bf8 to e0dcf4c Compare November 12, 2024 04:23
@Naireen
Copy link
Contributor Author

Naireen commented Nov 12, 2024

Run Java_Pulsar_IO_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Nov 12, 2024

Run Java_PVR_Prism_Loopback PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Nov 12, 2024

Run Java_IOs_Direct PreCommit

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (b3e7f55) to head (9929cef).
Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33043      +/-   ##
============================================
- Coverage     59.03%   59.00%   -0.03%     
- Complexity     3186     3193       +7     
============================================
  Files          1146     1147       +1     
  Lines        176129   176150      +21     
  Branches       3366     3375       +9     
============================================
- Hits         103975   103945      -30     
- Misses        68800    68843      +43     
- Partials       3354     3362       +8     
Flag Coverage Δ
java 70.29% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch from e0dcf4c to 377f753 Compare November 12, 2024 05:54
@Naireen
Copy link
Contributor Author

Naireen commented Nov 12, 2024

Run Java PreCommit

@Naireen Naireen marked this pull request as ready for review November 12, 2024 16:51
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java.
R: @damondouglas for label io.
R: @johnjcasey for label kafka.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Copy link
Contributor

Reminder, please take a look at this pr: @damondouglas @damondouglas @johnjcasey

@Naireen Naireen marked this pull request as draft December 18, 2024 22:55
@Naireen
Copy link
Contributor Author

Naireen commented Dec 18, 2024

Going to move this into a draft state, will clean up and send for review again soon.

Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @Abacn for label io.
R: @Abacn for label kafka.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Copy link
Contributor

Reminder, please take a look at this pr: @robertwb @Abacn @Abacn

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java.
R: @johnjcasey for label io.
R: @johnjcasey for label kafka.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch 3 times, most recently from a52840d to 552c9a7 Compare January 7, 2025 21:58
@Naireen Naireen force-pushed the add_histogram_to_metrics_container branch from 552c9a7 to 9929cef Compare January 8, 2025 20:08
@Naireen
Copy link
Contributor Author

Naireen commented Jan 8, 2025

Run Java_Flink_Versions PreCommit

1 similar comment
@Naireen
Copy link
Contributor Author

Naireen commented Jan 8, 2025

Run Java_Flink_Versions PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 8, 2025

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 8, 2025

Run Java_PVR_Prism_Loopback PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 8, 2025

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 8, 2025

Run Java_Flink_Versions PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 8, 2025

Not clear why flink tests are failing, but the java precommit tests are running into issue #28957

@Naireen
Copy link
Contributor Author

Naireen commented Jan 8, 2025

Run Java_Flink_Versions PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 8, 2025

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Jan 8, 2025

Run Java_Flink_Versions PreCommit

1 similar comment
@Naireen
Copy link
Contributor Author

Naireen commented Jan 9, 2025

Run Java_Flink_Versions PreCommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants