Skip to content

Commit

Permalink
Merge pull request #29785: Fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
chamikaramj authored Dec 21, 2023
2 parents 7e4dc66 + 6499c65 commit 78e231a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ static class BigQueryIOWriteTranslator implements TransformPayloadTranslator<Wri
.addNullableBooleanField("propagate_successful_storage_api_writes")
.addNullableInt32Field("max_files_per_partition")
.addNullableInt64Field("max_bytes_per_partition")
.addNullableLogicalTypeField("triggerring_frequency", new NanosDuration())
.addNullableLogicalTypeField("triggering_frequency", new NanosDuration())
.addNullableByteArrayField("method")
.addNullableStringField("load_job_project_id")
.addNullableByteArrayField("failed_insert_retry_policy")
Expand Down Expand Up @@ -477,7 +477,7 @@ public Row toConfigRow(Write<?> transform) {
fieldValues.put("max_bytes_per_partition", transform.getMaxBytesPerPartition());
if (transform.getTriggeringFrequency() != null) {
fieldValues.put(
"triggerring_frequency",
"triggering_frequency",
Duration.ofMillis(transform.getTriggeringFrequency().getMillis()));
}
if (transform.getMethod() != null) {
Expand Down Expand Up @@ -695,11 +695,11 @@ public Write<?> fromConfigRow(Row configRow) {
if (maxBytesPerPartition != null) {
builder = builder.setMaxBytesPerPartition(maxBytesPerPartition);
}
Duration triggerringFrequency = configRow.getValue("triggerring_frequency");
if (triggerringFrequency != null) {
Duration triggeringFrequency = configRow.getValue("triggering_frequency");
if (triggeringFrequency != null) {
builder =
builder.setTriggeringFrequency(
org.joda.time.Duration.millis(triggerringFrequency.toMillis()));
org.joda.time.Duration.millis(triggeringFrequency.toMillis()));
}
byte[] methodBytes = configRow.getBytes("method");
if (methodBytes != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public class BigQueryIOTranslationTest {
"getPropagateSuccessfulStorageApiWrites", "propagate_successful_storage_api_writes");
WRITE_TRANSFORM_SCHEMA_MAPPING.put("getMaxFilesPerPartition", "max_files_per_partition");
WRITE_TRANSFORM_SCHEMA_MAPPING.put("getMaxBytesPerPartition", "max_bytes_per_partition");
WRITE_TRANSFORM_SCHEMA_MAPPING.put("getTriggeringFrequency", "triggerring_frequency");
WRITE_TRANSFORM_SCHEMA_MAPPING.put("getTriggeringFrequency", "triggering_frequency");
WRITE_TRANSFORM_SCHEMA_MAPPING.put("getMethod", "method");
WRITE_TRANSFORM_SCHEMA_MAPPING.put("getLoadJobProjectId", "load_job_project_id");
WRITE_TRANSFORM_SCHEMA_MAPPING.put("getFailedInsertRetryPolicy", "failed_insert_retry_policy");
Expand Down

0 comments on commit 78e231a

Please sign in to comment.