Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-4104: [Python]: Drop support for Python 3.7 and 3.8 #3221

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

martin-g
Copy link
Member

Both of them are EOLed and cause problems with the CI checks

What is the purpose of the change

(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)

Verifying this change

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Extended interop tests to verify consistent valid schema names between SDKs
  • Added test that validates that Java throws an AvroRuntimeException on invalid binary data
  • Manually verified the change by building the website and checking the new redirect

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@martin-g martin-g requested a review from kojiromike October 25, 2024 13:27
@martin-g martin-g marked this pull request as draft October 25, 2024 13:27
@martin-g
Copy link
Member Author

TODO: Create a JIRA ticket if this is approved!

Both of them are EOLed and cause problems with the CI checks

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g force-pushed the remove-python-37-and-38 branch from acc8faf to 6e4296d Compare October 25, 2024 13:31
@@ -71,10 +71,6 @@ RUN apt-get -qqy update \
python3.10 \
python3.11 \
python3.11-dev \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it time to add 3.12 here ?

Copy link
Member

@Xuanwo Xuanwo Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that version 3.13 has been released, I think it's about time.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@@ -21,7 +21,7 @@ on:
pull_request:
branches: [ main ]
paths:
- .github/workflows/test-lang-py.yml
- .github/workflows/test-lang-py-ARM.yml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ARM64 VMs are self-hosted by ASF Infra and they use Ubuntu 20.04 with an old Python version in the OS repos ...
This should be re-worked to use Conda or something similar to install a newer version of Python.

@martin-g martin-g force-pushed the remove-python-37-and-38 branch from e0342de to 5bb4de0 Compare October 29, 2024 13:40
@martin-g martin-g marked this pull request as ready for review December 30, 2024 14:10
@martin-g martin-g changed the title [Python]: Drop support for Python 3.7 and 3.8 AVRO-4104: [Python]: Drop support for Python 3.7 and 3.8 Dec 30, 2024
@martin-g martin-g requested a review from Fokko December 30, 2024 14:10
@martin-g
Copy link
Member Author

Semi-duplicate of #3276

Comment on lines +56 to 58
sudo update-alternatives --set python /usr/bin/python3.12
sudo update-alternatives --set python3 /usr/bin/python3.12
python3 -m pip install --upgrade pip setuptools tox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wuff, I don't know what version of pip python3-pip gets us, but the code that caused the failure was removed in pypa/pip@6739f56, which was released in v21.0 (the first release of 2021).

Anyway, I guess to work around it we need to update pip using a version of python that is before 3.12. IIUC, python3.8 is still here, so python3.8 -m pip install --upgrade pip setuptools tox.

(For now, at least, the latest pip is still compatible with python 3.8, or we might need to get more boot-strappy.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants