Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA Improve pdf docs layout #3251

Closed
wants to merge 1 commit into from
Closed

NO-JIRA Improve pdf docs layout #3251

wants to merge 1 commit into from

Conversation

brusdev
Copy link
Member

@brusdev brusdev commented Sep 1, 2020

No description provided.

@clebertsuconic
Copy link
Contributor

are you sure it fixed...

The bookmarks on the left on PDF are not navigating.

(the chapter links are working fine though)

@brusdev
Copy link
Member Author

brusdev commented Sep 4, 2020

@clebertsuconic this is just a workaround to fix the layout (header and footer) of pdfs generated by the last versions of gitbook. ATM I can't find a workaround to fix the bookmarks too.

@brusdev brusdev force-pushed the improve_pdf_docs branch 2 times, most recently from 0ddb8d9 to 34140db Compare September 6, 2020 14:31
@brusdev
Copy link
Member Author

brusdev commented Sep 6, 2020

@clebertsuconic finally I have found the cause of the bookmarks issue: GitbookIO/theme-default#80
I have overloaded the gitbook default theme page.html to get around the issue until the next release of gitbook.

@brusdev
NO-JIRA Fix PDF header and table of content
80082e3 
Override the default theme page.html of gitbook to fix the issue at
GitbookIO/theme-default#80
@asfgit asfgit closed this in 7951e16 Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brusdev @clebertsuconic