Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hsl(0deg, 100%, 50%) #192

Closed
wants to merge 1 commit into from
Closed

Support hsl(0deg, 100%, 50%) #192

wants to merge 1 commit into from

Conversation

tribela
Copy link
Contributor

@tribela tribela commented Jan 13, 2024

This pr add support hsl(0deg, 100%, 50%);

@ap
Copy link
Owner

ap commented Jan 13, 2024

Thank you for the patch. I’ve pushed it as faa6593.

Properly supporting deg values needs more work because the patch as is makes the plugin accept nonsense like rgb(30deg,30deg,30deg). But the plugin is no longer fully up to date with CSS specs anyway, and the changes needed to make it compliant will be much bigger than just a few tweaks to this patch. So I decided to file #193 for those changes and to take your patch as is in the meantime.

Thank you for providing it and for prompting me to check the plugin against at the current state of the specs.

@ap ap closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants