Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch around MUI icons failure to work in ESM project #731

Merged
merged 2 commits into from
Feb 21, 2023
Merged

fix: patch around MUI icons failure to work in ESM project #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5baa198
fix: patch around MUI icons failure to work in ESM project
steveluscher Feb 21, 2023
78df168
Create proud-trees-destroy.md
steveluscher Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/proud-trees-destroy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@solana/wallet-adapter-example": patch
"@solana/wallet-adapter-material-ui": patch
---

Updated imports of Material UI icons in such a way that sidesteps the problem described here: https://github.com/mui/material-ui/issues/35233
5 changes: 4 additions & 1 deletion packages/starter/example/src/components/notify.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import LaunchIcon from '@mui/icons-material/Launch';
import {
// FIXME(https://github.com/mui/material-ui/issues/35233)
Launch as LaunchIcon,
} from '@mui/icons-material';
import { Link } from '@mui/material';
import { styled } from '@mui/material/styles';
import type { VariantType } from 'notistack';
Expand Down
12 changes: 8 additions & 4 deletions packages/ui/material-ui/src/WalletDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import CloseIcon from '@mui/icons-material/Close';
import CollapseIcon from '@mui/icons-material/ExpandLess';
import ExpandIcon from '@mui/icons-material/ExpandMore';

import {
// FIXME(https://github.com/mui/material-ui/issues/35233)
Close as CloseIcon,
// FIXME(https://github.com/mui/material-ui/issues/35233)
ExpandLess as CollapseIcon,
// FIXME(https://github.com/mui/material-ui/issues/35233)
ExpandMore as ExpandIcon,
} from '@mui/icons-material';
import type { DialogProps, Theme } from '@mui/material';
import {
Button,
Expand Down
12 changes: 8 additions & 4 deletions packages/ui/material-ui/src/WalletMultiButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import CopyIcon from '@mui/icons-material/FileCopy';
import DisconnectIcon from '@mui/icons-material/LinkOff';
import SwitchIcon from '@mui/icons-material/SwapHoriz';

import {
// FIXME(https://github.com/mui/material-ui/issues/35233)
FileCopy as CopyIcon,
// FIXME(https://github.com/mui/material-ui/issues/35233)
LinkOff as DisconnectIcon,
// FIXME(https://github.com/mui/material-ui/issues/35233)
SwapHoriz as SwitchIcon,
} from '@mui/icons-material';
import type { ButtonProps, Theme } from '@mui/material';
import { Button, Collapse, Fade, ListItemIcon, Menu, MenuItem, styled } from '@mui/material';
import { useWallet } from '@solana/wallet-adapter-react';
Expand Down