fix: return error if no welcome message received

anycable · Aug 15, 2023 · 4efc679 · 4efc679
1 parent 1e5b70f
commit 4efc679
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cable.go b/cable.go
@@ -140,7 +140,8 @@ func (c *Cable) Connect(cableUrl string, opts goja.Value) (*Client, error) {
 	err = client.start()
 
 	if err != nil {
-		return nil, err
+		logger.Errorf("failed to initialize Action Cable connection: %v", err)
+		return nil, nil
 	}
 
 	return &client, nil

diff --git a/client.go b/client.go
@@ -281,8 +281,7 @@ func (c *Client) receiveWelcomeMsg() error {
 	}
 
 	if obj.Type != "welcome" {
-		c.logger.Errorf("expected welcome msg, got %v", obj)
-		return err
+		return fmt.Errorf("expected welcome msg, got %v", obj)
 	}
 
 	return nil