Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Action Cable decodes and re-encodes every broadcasted message for every client which is unnecessary in most cases. This PR provides a
fastlane_broadcasts
configuration option to skip double encoding and transmit broadcast messages as is to clients not using custom stream coders or user-defined callbacks.This is a continuation of the previous work: rails/rails#26999
Benchmarks
The cost of excess encoding heavily depends on the broadcasting payload size and nature. We consider three examples: a small JSON, a larger JSON, and a Turbo Stream "append" action.
Here are the results:
So, for small JSON payloads the fastlane version is ~3x faster, for larger JSON — ~7x faster, for HTML/Hotwire payloads — ~5x faster.
Here are Vernier profile screenshots: