-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for keccak256 #42
Conversation
@antouhou i added support for keccak256 and some basic testing for it !! plz review it |
Hey @Haxry ! Thank you for the PR, amazing! Would it be possible to lock it behind a feature? Thank you a lot! |
@antouhou i have locked it behind a feature!! plz review! |
Cargo.toml
Outdated
@@ -15,6 +15,7 @@ exclude = ["/ci/*", "/scripts/*", "/.github/*", "/bors.toml"] | |||
|
|||
[dependencies] | |||
sha2 = { version = "0.10", default-features = false } | |||
tiny-keccak = { version = "2.0", features = ["keccak"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny-keccak = { version = "2.0", features = ["keccak"] } | |
tiny-keccak = { version = "2.0", features = ["keccak"], optional=true } |
@Haxry thank you! I've added the suggestion to the to make |
@antouhou yeh let me change that |
@antouhou plz check now |
Hey @Haxry, I've published version 1.5.0 to crates.io. Thanks for the PR! |
closes #34