Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for keccak256 #42

Merged
merged 6 commits into from
Feb 24, 2025
Merged

add support for keccak256 #42

merged 6 commits into from
Feb 24, 2025

Conversation

Haxry
Copy link
Contributor

@Haxry Haxry commented Feb 13, 2025

closes #34

@Haxry
Copy link
Contributor Author

Haxry commented Feb 13, 2025

@antouhou i added support for keccak256 and some basic testing for it !!

plz review it

@antouhou
Copy link
Owner

Hey @Haxry ! Thank you for the PR, amazing! Would it be possible to lock it behind a feature? Thank you a lot!

@Haxry
Copy link
Contributor Author

Haxry commented Feb 24, 2025

@antouhou i have locked it behind a feature!! plz review!

Cargo.toml Outdated
@@ -15,6 +15,7 @@ exclude = ["/ci/*", "/scripts/*", "/.github/*", "/bors.toml"]

[dependencies]
sha2 = { version = "0.10", default-features = false }
tiny-keccak = { version = "2.0", features = ["keccak"] }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tiny-keccak = { version = "2.0", features = ["keccak"] }
tiny-keccak = { version = "2.0", features = ["keccak"], optional=true }

@antouhou
Copy link
Owner

@Haxry thank you! I've added the suggestion to the to make tiny-keccak optional, also you need to add keccak256 = ["tiny-keccak"] under the features section in cargo.toml (I can't add suggestion there, as cargo.toml hasn't been changed in the PR). Also please run cargo fmt afterward, the CI system is a bit unhappy about the newlines. I'll merge and publish a new version after that :) Thank you!

@Haxry
Copy link
Contributor Author

Haxry commented Feb 24, 2025

@antouhou yeh let me change that

@Haxry
Copy link
Contributor Author

Haxry commented Feb 24, 2025

@antouhou plz check now

@antouhou antouhou merged commit fc0d001 into antouhou:master Feb 24, 2025
4 checks passed
@antouhou
Copy link
Owner

Hey @Haxry, I've published version 1.5.0 to crates.io. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not support sha3::keccak256?
2 participants