-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre flight check fail on cis_target_os_versions and privileged binaries list not populating #76
Open
yobooooi
wants to merge
126
commits into
anthcourtney:build
Choose a base branch
from
yobooooi:master
base: build
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added .idea directory to be ignored from git
Added changes for NTP to have it meet CIS spec
added tagging to 2.2.1.2
Remove Section 2 task from this branch Put back tasks/level-1/2.2.1.2.yml to fix the merge conflict
…inux into section-1
…ly re-enabled as we progress thru sections.
…login for ExecStart
DIADO-3138 CIS remediation bugfixes
3.6 also check for boot loader configuration file's existence beofre attempting to modify it Revert the licence back to MIT in role metadata
DIADO-3138 Assorted fixes
5.3.4 Fix task labels
DIADO-3451: properly set unlock_time to 1800
…e_distribution_version
…gs to ensure list is populated so it can be stored by subsequent task
Hey Adan (@yobooooi ), thank you for the PR :) |
Hey Adan (@yobooooi ), can you please resolve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the latest AMI the
ansible_distribution_version
is2
. Needed to update thecis_target_os_versions
to support2
for the pre-flight check to pass for the playbook to run.Task 4.1.12 Populate a list of privileged binaries, was not running with tag level-1 and the task 4.1.12 Ensure use of privileged commands is collected (Scored) is dependant on that list of binaries. Added the tags that so that the task could execute and the list and be collected and stored.