Bugfix: Correct calendar week date calculation logic #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in `get_start_and_end_date_from_calendar_week` where the first calendar week was incorrectly determined. Adjusted the logic to compute the correct week start date based on ISO week rules. Added comprehensive test cases to ensure proper functionality for edge cases.
Update version number in the ambient_toolbox package. This prepares the package for a new release with potential fixes or enhancements.
Replace hardcoded integer comparison with `calendar.Day.THURSDAY` for clarity and maintainability. This ensures proper handling of weekdays when calculating the nearest Monday for the given year.
Replaced the `calendar.Day.THURSDAY` enum reference with a more explicit constant value (`3`). This improves readability and eliminates dependency on the `calendar` module's enum for this specific use case.
GitRon
reviewed
Jan 17, 2025
Replaced the hardcoded magic number for Thursday with the `calendar.THURSDAY` constant to improve code readability and maintainability. This change ensures better clarity and alignment with Python's standard library practices.
GitRon
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
get_start_and_end_date_from_calendar_weekwhere the first calendar week was incorrectly determined. Adjusted the logic to compute the correct week start date based on ISO week rules. Added comprehensive test cases to ensure proper functionality for edge cases.Bärbel and I stumbled upon this 🫠🫠🫠