v9.5.1

.ambient-package-update/metadata.py

@@ -63,6 +63,7 @@
         "dev": [
             *DEV_DEPENDENCIES,
             "gevent~=23.9",
+            "httpx~=0.27",
         ],
         "drf": [
             "djangorestframework>=3.8.2",

CHANGES.md

@@ -1,5 +1,8 @@
 # Changelog
 
+**9.5.1** (2024-02-28)
+  * Fixed bug in coverage script that a set `GITLAB_CI_DISABLE_COVERAGE` would always skip coverage check
+
 **9.5.0** (2024-02-02)
   * Added django message test helper method `assert_message_not_in_request`
 

ambient_toolbox/__init__.py

@@ -1,3 +1,3 @@
 """Python toolbox of Ambient Digital containing an abundance of useful tools and gadgets."""
 
-__version__ = "9.5.0"
+__version__ = "9.5.1"

ambient_toolbox/gitlab/coverage.py

@@ -30,7 +30,20 @@ def __init__(self) -> None:
         )
         self.pipelines_url_with_token = f"{self.pipelines_url}&private_token={self.token}"
 
-        self.disable_coverage: bool = os.environ.get("GITLAB_CI_DISABLE_COVERAGE", False)
+        self.disable_coverage: bool = self.get_disable_coverage(os.environ.get("GITLAB_CI_DISABLE_COVERAGE", "0"))
+
+    @staticmethod
+    def get_disable_coverage(disable_env: str) -> bool:
+        disable_coverage = disable_env
+
+        if disable_coverage.lower() == "true":
+            return True
+        elif disable_coverage.lower() == "false":
+            return False
+        elif disable_coverage.isdigit():
+            return bool(int(disable_coverage))
+        else:
+            return bool(disable_coverage)
 
     def get_latest_target_branch_commit_sha(self) -> str:
         """

tests/gitlab/test_coverage.py

@@ -0,0 +1,43 @@
+from unittest import mock
+
+from django.test import SimpleTestCase
+
+from ambient_toolbox.gitlab.coverage import CoverageService
+
+
+@mock.patch.dict("os.environ", {"CI_PIPELINE_ID": "17", "CI_PROJECT_ID": "27"})
+class CoverageServiceTest(SimpleTestCase):
+    def test_get_disable_coverage_integer_false(self):
+        service = CoverageService()
+        result = service.get_disable_coverage(disable_env="0")
+
+        self.assertIsInstance(result, bool)
+        self.assertFalse(result)
+
+    def test_get_disable_coverage_integer_true(self):
+        service = CoverageService()
+        result = service.get_disable_coverage(disable_env="1")
+
+        self.assertIsInstance(result, bool)
+        self.assertTrue(result)
+
+    def test_get_disable_coverage_string_var_bool_false(self):
+        service = CoverageService()
+        result = service.get_disable_coverage(disable_env="False")
+
+        self.assertIsInstance(result, bool)
+        self.assertFalse(result)
+
+    def test_get_disable_coverage_string_var_bool_true(self):
+        service = CoverageService()
+        result = service.get_disable_coverage(disable_env="True")
+
+        self.assertIsInstance(result, bool)
+        self.assertTrue(result)
+
+    def test_get_disable_coverage_string_var_random(self):
+        service = CoverageService()
+        result = service.get_disable_coverage(disable_env="Wololo")
+
+        self.assertIsInstance(result, bool)
+        self.assertTrue(result)