Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-1084: Test prover checkpoint runner with unreliable sequencer #686

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evgenyzdanovich
Copy link
Contributor

@evgenyzdanovich evgenyzdanovich commented Feb 24, 2025

Description

Re-purpose an existing prover_checkpoint_runner test to check for normal checkpoint proving when sequencer is unreliable.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@evgenyzdanovich evgenyzdanovich requested a review from a team as a code owner February 24, 2025 17:22
@evgenyzdanovich evgenyzdanovich force-pushed the str-1084-unreliable-prover-downstream-deps branch from 5a3503f to cf88b4a Compare February 24, 2025 17:25
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.47%. Comparing base (ff4da8d) to head (cf88b4a).

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   54.47%   54.47%           
=======================================
  Files         320      320           
  Lines       34407    34407           
=======================================
  Hits        18744    18744           
  Misses      15663    15663           

see 2 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 24, 2025

Commit: 6341f8e

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,501
EL_BLOCK 97,878
CL_BLOCK 93,599
L1_BATCH 30,419,221
L2_BATCH 3,432
CHECKPOINT 25,769

@evgenyzdanovich evgenyzdanovich marked this pull request as draft February 25, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant