Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config and args #669

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Add extra validation to config

5cd74a7
Select commit
Loading
Failed to load commit list.
Open

Update config and args #669

Add extra validation to config
5cd74a7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 25, 2025 in 0s

54.72% (+0.67%) compared to 403b15a

View this Pull Request on Codecov

54.72% (+0.67%) compared to 403b15a

Details

Codecov Report

Attention: Patch coverage is 54.79452% with 99 lines in your changes missing coverage. Please review.

Project coverage is 54.72%. Comparing base (403b15a) to head (5cd74a7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
bin/strata-client/src/main.rs 0.00% 43 Missing ⚠️
bin/strata-client/src/helpers.rs 0.00% 33 Missing ⚠️
bin/strata-client/src/args.rs 86.25% 18 Missing ⚠️
crates/config/src/config.rs 58.33% 5 Missing ⚠️
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   54.05%   54.72%   +0.67%     
==========================================
  Files         320      320              
  Lines       34158    34490     +332     
==========================================
+ Hits        18464    18876     +412     
+ Misses      15694    15614      -80     
Files with missing lines Coverage Δ
crates/config/src/btcio.rs 100.00% <ø> (+27.77%) ⬆️
crates/config/src/config.rs 90.90% <58.33%> (-5.17%) ⬇️
bin/strata-client/src/args.rs 86.80% <86.25%> (+86.80%) ⬆️
bin/strata-client/src/helpers.rs 0.00% <0.00%> (ø)
bin/strata-client/src/main.rs 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes