-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove boost::aligned_alloc #1094
remove boost::aligned_alloc #1094
Conversation
@BenjaminW3 could you please check on your windows system if our BOOST_COMP_MSVC is working correctly. |
I think I need to check for windows instead of msvc because nvcc is not msvc ^^. Is there a boost define for windows or do I need to use the define |
We often use |
for OSX we need to use |
todo: for aligned_alloc we need to round the size to a multiple of the alignment https://en.cppreference.com/w/c/memory/aligned_alloc |
- remove dependency to boost aligned allocation - remove boost in filenames which was providing aligned memory via boost implementations - add `AlignedAlloc.hpp`
thx, I found that there is a |
1be21fb
to
bd36cce
Compare
IMO it can be merged. all failing ci build run into download issues. |
I found here in PIConGPU that this PR is not working on systems with a very old glibc.
|
based on the suggestions from #481 (comment) and #481 (comment)
remove dependency to boost aligned allocation
remove boost in filenames which was providing aligned memory via boost
implementations
add
AlignedAlloc.hpp
need tests on OpenPower system