Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contract): remove fake transport and provider traits #1996

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(contract): remove fake transport and provider traits #1996

wants to merge 5 commits into from
+44 −55

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Feb 3, 2025 •
edited
Loading

Motivation

Since #1859, we have been using these

alloy/crates/contract/src/lib.rs

Line 43 in 370dbef

// This is done so that the compiler can infer the `T` type to be `()`, which is the only type
fake transport and provider traits to avoid breaking changes to the sol!.

This PR bumps core and removes the reliance on these fake traits and generics.

Solution

  • Remove re-export of fake Transport and Provider traits from alloy_contract
  • Remove T generic from CallBuilder and Event

Note:
This should be merged after alloy-rs/core#865.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya mentioned this pull request Feb 3, 2025
Open
3 tasks
@yash-atreya yash-atreya marked this pull request as draft February 3, 2025 13:57
@mattsse mattsse added the blocked This cannot move forward until something else changes label Feb 3, 2025
@yash-atreya yash-atreya marked this pull request as ready for review February 3, 2025 19:20
@yash-atreya yash-atreya added this to the v1.0 milestone Feb 28, 2025
@yash-atreya yash-atreya added enhancement New feature or request breaking Breaking changes have been made c-contract P-high High Priority labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@yash-atreya yash-atreya

Labels
blocked This cannot move forward until something else changes breaking Breaking changes have been made c-contract enhancement New feature or request P-high High Priority
Projects
Alloy
Status: Blocked
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yash-atreya @gakonst @DaniPopes @mattsse