Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kyrgyz language - small fixes #172

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Kyrgyz language - small fixes #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e658f5
filled additional test cases
jglaszka Jan 3, 2025
c9f429a
fix wildcard imports + change language code according to ISO 3166 sta…
jglaszka Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/main/java/pl/allegro/finance/tradukisto/MoneyConverters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,30 @@
import java.math.BigDecimal;
import java.util.Objects;

import static pl.allegro.finance.tradukisto.internal.Container.*;
import static pl.allegro.finance.tradukisto.internal.Container.americanEnglishContainer;
import static pl.allegro.finance.tradukisto.internal.Container.brazilianPortugueseContainer;
import static pl.allegro.finance.tradukisto.internal.Container.croatianContainer;
import static pl.allegro.finance.tradukisto.internal.Container.czechContainer;
import static pl.allegro.finance.tradukisto.internal.Container.englishContainer;
import static pl.allegro.finance.tradukisto.internal.Container.frenchContainer;
import static pl.allegro.finance.tradukisto.internal.Container.germanContainer;
import static pl.allegro.finance.tradukisto.internal.Container.italianContainer;
import static pl.allegro.finance.tradukisto.internal.Container.japaneseKanjiContainer;
import static pl.allegro.finance.tradukisto.internal.Container.kazakhContainer;
import static pl.allegro.finance.tradukisto.internal.Container.latvianContainer;
import static pl.allegro.finance.tradukisto.internal.Container.polishContainer;
import static pl.allegro.finance.tradukisto.internal.Container.russianContainer;
import static pl.allegro.finance.tradukisto.internal.Container.serbianCyrillicContainer;
import static pl.allegro.finance.tradukisto.internal.Container.serbianContainer;
import static pl.allegro.finance.tradukisto.internal.Container.slovakContainer;
import static pl.allegro.finance.tradukisto.internal.Container.sloveneContainer;
import static pl.allegro.finance.tradukisto.internal.Container.spanishContainer;
import static pl.allegro.finance.tradukisto.internal.Container.swedishContainer;
import static pl.allegro.finance.tradukisto.internal.Container.turkishContainer;
import static pl.allegro.finance.tradukisto.internal.Container.ukrainianContainer;
import static pl.allegro.finance.tradukisto.internal.Container.bulgarianContainer;
import static pl.allegro.finance.tradukisto.internal.Container.dutchContainer;
import static pl.allegro.finance.tradukisto.internal.Container.kyrgyzContainer;

public enum MoneyConverters {

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/pl/allegro/finance/tradukisto/ValueConverters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public enum ValueConverters {
SLOVAK_INTEGER(Container.slovakContainer().getIntegerConverter(), "sk"),
LATVIAN_INTEGER(Container.latvianContainer().getIntegerConverter(), "lv"),
KAZAKH_INTEGER(Container.kazakhContainer().getIntegerConverter(), "kk"),
KYRGYZ_INTEGER(Container.kyrgyzContainer().getIntegerConverter(), "kg"),
KYRGYZ_INTEGER(Container.kyrgyzContainer().getIntegerConverter(), "ky"),
UKRAINIAN_INTEGER(Container.ukrainianContainer().getIntegerConverter(), "uk"),
SERBIAN_INTEGER(Container.serbianContainer().getIntegerConverter(), Arrays.asList("sr", getLanguageCodeFor("sr", "Latn"))),
SERBIAN_CYRILLIC_INTEGER(Container.serbianCyrillicContainer().getIntegerConverter(), getLanguageCodeFor("sr", "Cyrl")),
Expand Down
4 changes: 2 additions & 2 deletions src/test/groovy/pl/allegro/finance/tradukisto/ValueConvertersTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class ValueConvertersTest extends Specification {
new Locale("de") || GERMAN_INTEGER
Locale.GERMANY || GERMAN_INTEGER
new Locale("kk") || KAZAKH_INTEGER
new Locale("kg") || KYRGYZ_INTEGER
new Locale("ky") || KYRGYZ_INTEGER
new Locale("lv") || LATVIAN_INTEGER
new Locale("pl") || POLISH_INTEGER
new Locale("ru") || RUSSIAN_INTEGER
Expand Down Expand Up @@ -146,7 +146,7 @@ class ValueConvertersTest extends Specification {
"it" || ITALIAN_INTEGER
"de" || GERMAN_INTEGER
"kk" || KAZAKH_INTEGER
"kg" || KYRGYZ_INTEGER
"ky" || KYRGYZ_INTEGER
"lv" || LATVIAN_INTEGER
"pl" || POLISH_INTEGER
"ru" || RUSSIAN_INTEGER
Expand Down
43 changes: 36 additions & 7 deletions ...st/groovy/pl/allegro/finance/tradukisto/internal/languages/kyrgyz/KyrgyzValuesTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,19 @@ class KyrgyzValuesTest extends Specification {
90 | "токсон"
100 | "жүз"

21 | "жыйырма бир"
25 | "жыйырма беш"
34 | "отуз төрт"
37 | "отуз жети"
43 | "кырк үч"
51 | "элүү бир"
58 | "элүү сегиз"
69 | "алтымыш тогуз"
76 | "жетимиш алты"
82 | "сексен эки"
89 | "сексен тогуз"
95 | "токсон беш"

200 | "эки жүз"
300 | "үч жүз"
400 | "төрт жүз"
Expand All @@ -61,18 +74,22 @@ class KyrgyzValuesTest extends Specification {
900 | "тогуз жүз"
1000 | "бир миң"

1_000_000 | "бир миллион"
1_000_000_000 | "бир миллиард"

25 | "жыйырма беш"
34 | "отуз төрт"
51 | "элүү бир"
89 | "сексен тогуз"
111 | "жүз он бир"
144 | "жүз кырк төрт"
233 | "эки жүз отуз үч"
272 | "эки жүз жетимиш эки"
377 | "үч жүз жетимиш жети"
387 | "үч жүз сексен жети"
448 | "төрт жүз кырк сегиз"
569 | "беш жүз алтымыш тогуз"
610 | "алты жүз он"
625 | "алты жүз жыйырма беш"
777 | "жети жүз жетимиш жети"
782 | "жети жүз сексен эки"
895 | "сегиз жүз токсон беш"
987 | "тогуз жүз сексен жети"
999 | "тогуз жүз токсон тогуз"

1_597 | "бир миң беш жүз токсон жети"
2_584 | "эки миң беш жүз сексен төрт"
4_181 | "төрт миң жүз сексен бир"
Expand All @@ -87,10 +104,22 @@ class KyrgyzValuesTest extends Specification {
317_811 | "үч жүз он жети миң сегиз жүз он бир"
514_229 | "беш жүз он төрт миң эки жүз жыйырма тогуз"
832_040 | "сегиз жүз отуз эки миң кырк"

1_000_000 | "бир миллион"
2_000_000 | "эки миллион"
5_000_000 | "беш миллион"

1_346_269 | "бир миллион үч жүз кырк алты миң эки жүз алтымыш тогуз"
2_178_309 | "эки миллион жүз жетимиш сегиз миң үч жүз тогуз"
7_211_000 | "жети миллион эки жүз он бир миң"
23_437_219 | "жыйырма үч миллион төрт жүз отуз жети миң эки жүз он тогуз"
100_000_000 | "жүз миллион"
123_456_789 | "жүз жыйырма үч миллион төрт жүз элүү алты миң жети жүз сексен тогуз"
322_089_890 | "үч жүз жыйырма эки миллион сексен тогуз миң сегиз жүз токсон"

1_000_000_000 | "бир миллиард"
1_836_311_903 | "бир миллиард сегиз жүз отуз алты миллион үч жүз он бир миң тогуз жүз үч"
2_147_483_647 | "эки миллиард жүз кырк жети миллион төрт жүз сексен үч миң алты жүз кырк жети"
}

@Ignore("Needs kyrgyz long converter and values for trillion, quadrillion, quintillion")
Expand Down
Loading