resource/alicloud_rds_account: accountName support caseSensitivity #7982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitiansheng0524
force-pushed
the
fix_Account_caseinsensitive
branch
from
3da64f8 to
c766fd9
Compare
MrWolong
reviewed
Dec 16, 2024
| @@ -46,15 +46,15 @@ func resourceAlicloudRdsAccount() *schema.Resource { | |||
| Optional: true, | |||
| Computed: true, | |||
| ForceNew: true, | |||
| ValidateFunc: validation.StringMatch(regexp.MustCompile(`^[a-z][a-z0-9_]{0,61}[a-z0-9]$`), "The name can consist of lowercase letters, numbers, underscores, and must begin with letters and end with letters or numbers"), | |||
| ValidateFunc: validation.StringMatch(regexp.MustCompile(`^[a-zA-Z][a-zA-Z0-9_]{0,61}[a-zA-Z0-9]$`), "The name can consist of letters, numbers, underscores, and must begin with letters and end with letters or numbers"), | |||
There was a problem hiding this comment.
既然改了校验条件支持实例命名设置大写字母，那就应该在单测中体现
MrWolong
reviewed
Dec 16, 2024
| ConflictsWith: []string{"name"}, | ||
| }, | ||
| "name": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| ForceNew: true, | ||
| ValidateFunc: validation.StringMatch(regexp.MustCompile(`^[a-z][a-z0-9_]{0,61}[a-z0-9]$`), "The name can consist of lowercase letters, numbers, underscores, and must begin with letters and end with letters or numbers"), | ||
| ValidateFunc: validation.StringMatch(regexp.MustCompile(`^[a-zA-Z][a-zA-Z0-9_]{0,61}[a-zA-Z0-9]$`), "The name can consist of letters, numbers, underscores, and must begin with letters and end with letters or numbers"), |
There was a problem hiding this comment.
文档中的字段描述也改一下，现在还是只支持mysql类型的设置大写，还是所有类型都支持？
chaitiansheng0524
force-pushed
the
fix_Account_caseinsensitive
branch
from
a0306ea to
c1ed5a2
Compare
chaitiansheng0524
force-pushed
the
fix_Account_caseinsensitive
branch
from
c1ed5a2 to
37c68d0
Compare
chaitiansheng0524
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.