Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine: standardized error message #279

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

y1yang0
Copy link
Member

@y1yang0 y1yang0 commented Jan 7, 2025

related to #267

standardize error message, something like bellow

Command    : ../../otel go build xxx
ErrorLog   : .otel-build/preprocess/debug.log
WorkDir    : /home/yyang/opentelemetry-go-auto-instrumentation/test/helloworld
GoMod      : /home/yyang/opentelemetry-go-auto-instrumentation/test/helloworld/go.mod
GoVersion  : go1.22.0
ToolVersion: 0.4.0_8a27e33
OS         : linux/amd64
Code       : 1014
Message    : exit status 1
Cause      : goroutine 1 [running]:
runtime/debug.Stack()
        /usr/local/go/src/runtime/debug/stack.go:24 +0x5e
github.com/alibaba/opentelemetry-go-auto-instrumentation/tool/errc.New(0x3f6, {0xc000013160, 0xd})
        /home/yyang/opentelemetry-go-auto-instrumentation/tool/errc/errcode.go:57 +0x88
github.com/alibaba/opentelemetry-go-auto-instrumentation/tool/preprocess.runDryBuild({0xc0004136b0, 0x3, 0x3})
        /home/yyang/opentelemetry-go-auto-instrumentation/tool/preprocess/preprocess.go:475 +0x2a5
github.com/alibaba/opentelemetry-go-auto-instrumentation/tool/preprocess.(*DepProcessor).setupDeps(0xc00041c280)
        /home/yyang/opentelemetry-go-auto-instrumentation/tool/preprocess/preprocess.go:696 +0x86
github.com/alibaba/opentelemetry-go-auto-instrumentation/tool/preprocess.Preprocess()
        /home/yyang/opentelemetry-go-auto-instrumentation/tool/preprocess/preprocess.go:767 +0x136
main.main()
        /home/yyang/opentelemetry-go-auto-instrumentation/tool/cmd/main.go:184 +0x92

Detail.reason: package xxx is not in std (/usr/local/go/src/xxx)

Detail.command: [go build -a -x -n xxx]

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.86%. Comparing base (10697b5) to head (dddde3a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files          24       24           
  Lines        1033     1033           
=======================================
  Hits          856      856           
  Misses        144      144           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y1yang0 y1yang0 force-pushed the yyang/errrefine branch 8 times, most recently from da91f0c to 412fc6b Compare January 9, 2025 02:52
@NameHaibinZhang NameHaibinZhang self-requested a review January 9, 2025 05:34
@NameHaibinZhang NameHaibinZhang merged commit 2cb669a into main Jan 9, 2025
9 checks passed
@y1yang0 y1yang0 deleted the yyang/errrefine branch January 9, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants