Fix wrong error code for http open api request. (#12610)

alibaba · Sep 5, 2024 · 963b221 · 963b221
1 parent afee482
commit 963b221
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/config/src/main/java/com/alibaba/nacos/config/server/exception/GlobalExceptionHandler.java b/config/src/main/java/com/alibaba/nacos/config/server/exception/GlobalExceptionHandler.java
@@ -21,6 +21,8 @@
 import com.alibaba.nacos.common.utils.ExceptionUtil;
 import com.alibaba.nacos.config.server.monitor.MetricsMonitor;
 import com.alibaba.nacos.persistence.monitor.DatasourceMetrics;
+import org.springframework.core.Ordered;
+import org.springframework.core.annotation.Order;
 import org.springframework.dao.DataAccessException;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.ControllerAdvice;
@@ -33,7 +35,8 @@
  *
  * @author Nacos
  */
-@ControllerAdvice
+@ControllerAdvice(basePackages = "com.alibaba.nacos.config.server")
+@Order(Ordered.LOWEST_PRECEDENCE - 1)
 public class GlobalExceptionHandler {
 
     /**

diff --git a/naming/src/main/java/com/alibaba/nacos/naming/exception/ResponseExceptionHandler.java b/naming/src/main/java/com/alibaba/nacos/naming/exception/ResponseExceptionHandler.java
@@ -20,6 +20,8 @@
 import com.alibaba.nacos.api.exception.runtime.NacosRuntimeException;
 import com.alibaba.nacos.common.utils.ExceptionUtil;
 import com.alibaba.nacos.naming.misc.Loggers;
+import org.springframework.core.Ordered;
+import org.springframework.core.annotation.Order;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.MissingServletRequestParameterException;
@@ -31,7 +33,8 @@
  *
  * @author nkorange
  */
-@ControllerAdvice
+@ControllerAdvice(basePackages = "com.alibaba.nacos.naming")
+@Order(Ordered.LOWEST_PRECEDENCE - 1)
 public class ResponseExceptionHandler {
 
     /**

diff --git a/pom.xml b/pom.xml
@@ -88,7 +88,7 @@
     </issueManagement>
 
     <properties>
-        <revision>2.4.1</revision>
+        <revision>2.4.2-SNAPSHOT</revision>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <!-- Compiler settings properties -->