Multi-line parsing supports SIMD optimization #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zhongyuankai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
zhongyuankai
force-pushed
the
add_simd_support
branch
from
e1fdb43 to
46e9a4c
Compare
|
@zhongyuankai Can you share the performance comparison before and after this PR? |
|
@zhongyuankai Is it convenient to communicate on WeChat or DingTalk? |
|
@linrunqi08 Thank you for your reply. I have updated the comment. I am happy to communicate with you. How can I contact you on WeChat? |
|
@zhongyuankai You can add my WeChat ID: linrunqi08 |
yyuuttaaoo
reviewed
Dec 17, 2024
| const int vecSize = 32; | ||
| __m256i newlineVec = _mm256_set1_epi8('\n'); | ||
|
|
||
| for (int32_t pos = end - vecSize; pos >= 0; pos -= vecSize) { |
There was a problem hiding this comment.
如果不是32的整数倍长度怎么办？好像剩下的没检查？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the performance of parsing newlines through SIMD.
The following are the performance comparison test results under 150 tasks and 180MB/s traffic:
Before optimization:
After optimization:
After optimization, the performance is improved by about 8%. If the
GetNextLinemethod is tested separately, the performance is improved by 1 times.