Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(interactive): refactor runtime #4418

Merged
merged 35 commits into from
Jan 20, 2025
Merged

refactor(interactive): refactor runtime #4418

merged 35 commits into from
Jan 20, 2025

Conversation

liulx20
Copy link
Collaborator

@liulx20 liulx20 commented Jan 11, 2025

Fixes

@liulx20 liulx20 changed the title Refactor(interactive): refactor runtime refactor(interactive): refactor runtime Jan 11, 2025
@liulx20 liulx20 force-pushed the refactor branch 3 times, most recently from 05ecabe to d10a47e Compare January 11, 2025 15:03
@liulx20 liulx20 force-pushed the refactor branch 6 times, most recently from a497401 to d223e9b Compare January 16, 2025 03:02
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.73%. Comparing base (a60e912) to head (ee2c7a7).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4418      +/-   ##
==========================================
+ Coverage   33.11%   35.73%   +2.62%     
==========================================
  Files         126      126              
  Lines       13261    13261              
==========================================
+ Hits         4391     4739     +348     
+ Misses       8870     8522     -348

see 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60e912...ee2c7a7. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

Please check the preview of the documentation changes at
https://f2bb4daa.graphscope-docs-preview.pages.dev

luoxiaojian
luoxiaojian previously approved these changes Jan 17, 2025
View reviewed changes
zhanglei1949
zhanglei1949 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulx20 liulx20 requested a review from luoxiaojian January 20, 2025 03:49
@liulx20 liulx20 merged commit ebdf9d1 into alibaba:main Jan 20, 2025
30 of 32 checks passed
@zhanglei1949 zhanglei1949 mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanglei1949 zhanglei1949 zhanglei1949 approved these changes

@luoxiaojian luoxiaojian luoxiaojian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liulx20 @codecov-commenter @luoxiaojian @zhanglei1949