Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactive): Introducing sharding mode to Interactive #4410

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Jan 9, 2025

Introducing new configuration sharding_mode to Interactive. sharding_mode could be configured to exclusive or cooperative

  • exclusive: One shard(shard_id = shard_num - 1) will be reserved for only processing admin request
  • cooperative: All shard will processing both admin requests and query requests.

By default, sharding_mode is configured to exclusive to forbid admin service from being blocked by long-run queries. User could switch the mode via a config file.

To change the default value for a customized build, cmake .. -DDEFAULT_SHARDING_MODE=xxxx.

For the reason why this mode is introduced, see #4409

And also adding a CI and fix a bug.

Committed-by: [email protected] from Dev container
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Please check the preview of the documentation changes at
https://9d056e55.graphscope-docs-preview.pages.dev

Committed-by: [email protected] from Dev container
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.78%. Comparing base (3b0e2f7) to head (bac7fc7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4410   +/-   ##
=======================================
  Coverage   58.78%   58.78%           
=======================================
  Files          12       12           
  Lines         592      592           
=======================================
  Hits          348      348           
  Misses        244      244           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0e2f7...bac7fc7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants